-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds user context filter to dashboard calendar #7786
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
force-pushed
the
user-events-roles-filter
branch
2 times, most recently
from
April 25, 2024 17:05
08f3f5e
to
5099ff9
Compare
stopfstedt
force-pushed
the
user-events-roles-filter
branch
7 times, most recently
from
June 26, 2024 23:24
c140ba9
to
6a33121
Compare
stopfstedt
force-pushed
the
user-events-roles-filter
branch
2 times, most recently
from
July 1, 2024 19:27
40ff219
to
2450f35
Compare
stopfstedt
force-pushed
the
user-events-roles-filter
branch
from
July 3, 2024 17:17
d18ec5a
to
6efa1ee
Compare
jrjohnson
requested changes
Jul 5, 2024
packages/test-app/tests/integration/components/dashboard/user-context-filter-test.js
Show resolved
Hide resolved
stopfstedt
force-pushed
the
user-events-roles-filter
branch
from
July 8, 2024 19:36
6efa1ee
to
fe3949d
Compare
stopfstedt
force-pushed
the
user-events-roles-filter
branch
2 times, most recently
from
July 9, 2024 00:10
ed40185
to
407a452
Compare
stopfstedt
force-pushed
the
user-events-roles-filter
branch
from
July 11, 2024 21:02
407a452
to
3ba540c
Compare
jrjohnson
reviewed
Jul 11, 2024
stopfstedt
force-pushed
the
user-events-roles-filter
branch
from
July 12, 2024 18:23
3ba540c
to
59a89bf
Compare
jrjohnson
approved these changes
Jul 12, 2024
stopfstedt
force-pushed
the
user-events-roles-filter
branch
from
July 12, 2024 21:20
75f0176
to
82f097c
Compare
I am not quite sure how to use percy - I was expecting to see the changes and approve them but it's a bit different now - not sure |
never mind now they showed up = weird |
this has become obsolete with the inclusion of "learner" as one of the possible user contexts - which makes this control potentially applicable to all users.
this button is dead code. the actual "clear filters" button is somewhere lower on that page.
…test. this requires reworking and fleshing out of existing page objects and tests.
this is more to the point and easier to work with.
…backed equivalent.
…e dashboard calendar.
stopfstedt
force-pushed
the
user-events-roles-filter
branch
from
July 18, 2024 18:05
d58ed3d
to
619bc11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs ilios/ilios#5399