Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds user context filter to dashboard calendar #7786

Merged
merged 33 commits into from
Jul 19, 2024

Conversation

stopfstedt
Copy link
Member

@stopfstedt stopfstedt force-pushed the user-events-roles-filter branch 2 times, most recently from 08f3f5e to 5099ff9 Compare April 25, 2024 17:05
@stopfstedt stopfstedt force-pushed the user-events-roles-filter branch 7 times, most recently from c140ba9 to 6a33121 Compare June 26, 2024 23:24
@stopfstedt stopfstedt force-pushed the user-events-roles-filter branch 2 times, most recently from 40ff219 to 2450f35 Compare July 1, 2024 19:27
@stopfstedt stopfstedt marked this pull request as ready for review July 1, 2024 21:45
@stopfstedt stopfstedt marked this pull request as draft July 8, 2024 19:38
@stopfstedt stopfstedt force-pushed the user-events-roles-filter branch 2 times, most recently from ed40185 to 407a452 Compare July 9, 2024 00:10
@stopfstedt stopfstedt marked this pull request as ready for review July 9, 2024 00:21
@stopfstedt stopfstedt requested a review from jrjohnson July 9, 2024 00:21
@dartajax
Copy link
Member

I am not quite sure how to use percy - I was expecting to see the changes and approve them but it's a bit different now - not sure

@dartajax
Copy link
Member

I am not quite sure how to use percy - I was expecting to see the changes and approve them but it's a bit different now - not sure

never mind now they showed up = weird

this has become obsolete with the inclusion of "learner" as one of the
possible user contexts - which makes this control potentially applicable
to all users.
this button is dead code.
the actual "clear filters" button is somewhere lower on that page.
…test.

this requires reworking and fleshing out of existing page objects and
tests.
this is more to the point and easier to work with.
@dartajax dartajax merged commit 85a6871 into ilios:master Jul 19, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants